Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_lb: allow ipv6 addresses for the private_ip_address property #6125

Merged
merged 6 commits into from
Mar 21, 2020
Merged

azurerm_lb: allow ipv6 addresses for the private_ip_address property #6125

merged 6 commits into from
Mar 21, 2020

Conversation

fabianofranz
Copy link
Contributor

The azure load balancer resource's frontend_ip_configuration argument assumes
the IP address is only going to be IPv4. This removes that restriction to be
in line with the rest of the terraform code that does not have that validation.

@ghost ghost added the size/XS label Mar 16, 2020
@katbyte katbyte changed the title Don't assume IPv4 IP address on load balancer azurerm_lb: Don't assume IPv4 IP addresses Mar 17, 2020
@katbyte katbyte added this to the v2.2.0 milestone Mar 17, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fabianofranz,

Is the issue that the ip address can be ipv4 or ipv6? if that is the case could we change the validation to accept either rather then any string?

@katbyte katbyte modified the milestones: v2.2.0, v2.3.0 Mar 18, 2020
The azure load balancer resource's frontend_ip_configuration argument assumes
the IP address is only going to be IPv4. This removes that restriction to be
in line with the rest of the terraform code that does not have that validation.
@fabianofranz
Copy link
Contributor Author

Is the issue that the ip address can be ipv4 or ipv6? if that is the case could we change the validation to accept either rather then any string?

Done, changed to either accept IPv4, IPv6, or empty.

@ghost ghost removed the waiting-response label Mar 20, 2020
@fabianofranz
Copy link
Contributor Author

@katbyte ^

@ghost ghost added size/M and removed size/XS labels Mar 20, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabianofranz,

Thanks for the change, however there is a existing function in the SDK so i hope you don't mind but i've pushed some changes to get this merged 🙂 LGTM now 👍

@katbyte katbyte changed the title azurerm_lb: Don't assume IPv4 IP addresses azurerm_lb: allow ipv6 addresses for the private_ip_address property Mar 21, 2020
@katbyte katbyte merged commit 8fe2f86 into hashicorp:master Mar 21, 2020
katbyte added a commit that referenced this pull request Mar 21, 2020
@fabianofranz
Copy link
Contributor Author

@katbyte looks good, thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants