-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_lb: allow ipv6 addresses for the private_ip_address
property
#6125
azurerm_lb: allow ipv6 addresses for the private_ip_address
property
#6125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fabianofranz,
Is the issue that the ip address can be ipv4 or ipv6? if that is the case could we change the validation to accept either rather then any string?
The azure load balancer resource's frontend_ip_configuration argument assumes the IP address is only going to be IPv4. This removes that restriction to be in line with the rest of the terraform code that does not have that validation.
Done, changed to either accept IPv4, IPv6, or empty. |
@katbyte ^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change, however there is a existing function in the SDK so i hope you don't mind but i've pushed some changes to get this merged 🙂 LGTM now 👍
private_ip_address
property
@katbyte looks good, thanks! |
This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.3.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
The azure load balancer resource's frontend_ip_configuration argument assumes
the IP address is only going to be IPv4. This removes that restriction to be
in line with the rest of the terraform code that does not have that validation.