Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_function_app - support for daily_memory_time_quota #6100

Merged
merged 2 commits into from
Mar 16, 2020
Merged

azurerm_function_app - support for daily_memory_time_quota #6100

merged 2 commits into from
Mar 16, 2020

Conversation

aqche
Copy link
Contributor

@aqche aqche commented Mar 12, 2020

Fixes: #6076

Adds the daily_memory_time_quota option to the azurerm_function_app resource.

=== RUN   TestAccAzureRMFunctionApp_dailyMemoryTimeQuota
=== PAUSE TestAccAzureRMFunctionApp_dailyMemoryTimeQuota
=== CONT  TestAccAzureRMFunctionApp_dailyMemoryTimeQuota
--- PASS: TestAccAzureRMFunctionApp_dailyMemoryTimeQuota (200.69s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/web/tests   200.725s

"daily_memory_time_quota": {
Type: schema.TypeInt,
Optional: true,
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like if the value of DailyMemoryTimeQuota is set to 0 or a negative value, then the quota will be turned off. I know schema.TypeInt will default to a value of 0 if not provided. Do we want to explicitly set a default value here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should be fine - since the quota itself only affects functions inside a consumption plan?

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

"daily_memory_time_quota": {
Type: schema.TypeInt,
Optional: true,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should be fine - since the quota itself only affects functions inside a consumption plan?

@tombuildsstuff
Copy link
Contributor

Ignoring a couple of known test errors (and the linting errors fixed in #6118) this otherwise LGTM:

Screenshot 2020-03-16 at 10 22 45

@tombuildsstuff tombuildsstuff merged commit 65c55d2 into hashicorp:master Mar 16, 2020
@tombuildsstuff tombuildsstuff added this to the v2.2.0 milestone Mar 16, 2020
tombuildsstuff added a commit that referenced this pull request Mar 16, 2020
@aqche aqche deleted the azurerm_function_app_daily_memory_time_quota branch March 18, 2020 06:17
@ghost
Copy link

ghost commented Mar 18, 2020

This has been released in version 2.2.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.2.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for configuring "Daily Usage Quota" in azurerm_function_app
2 participants