Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource: azurerm_hpc_cache_blob_target #6035

Merged
merged 2 commits into from
Mar 20, 2020

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Mar 9, 2020

This partially address #6014. Once it is merged, I'll go on implementing azurerm_hpc_cache_nfs_target.

@magodo
Copy link
Collaborator Author

magodo commented Mar 9, 2020

💤  terraform-provider-azurerm [azurerm_hpc_cache_blob_target] ⚡  make testacc TEST="./azurerm/internal/services/storage/tests" TESTARGS="-run='TestAccAzureRMHPCCacheBlobTarget_'"
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
TF_ACC=1 go test ./azurerm/internal/services/storage/tests -v -run='TestAccAzureRMHPCCacheBlobTarget_' -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMHPCCacheBlobTarget_basic
=== PAUSE TestAccAzureRMHPCCacheBlobTarget_basic
=== RUN   TestAccAzureRMHPCCacheBlobTarget_update
=== PAUSE TestAccAzureRMHPCCacheBlobTarget_update
=== RUN   TestAccAzureRMHPCCacheBlobTarget_requiresImport
=== PAUSE TestAccAzureRMHPCCacheBlobTarget_requiresImport
=== CONT  TestAccAzureRMHPCCacheBlobTarget_basic
=== CONT  TestAccAzureRMHPCCacheBlobTarget_requiresImport
=== CONT  TestAccAzureRMHPCCacheBlobTarget_update
--- PASS: TestAccAzureRMHPCCacheBlobTarget_basic (2199.12s)
--- PASS: TestAccAzureRMHPCCacheBlobTarget_requiresImport (2561.70s)
--- PASS: TestAccAzureRMHPCCacheBlobTarget_update (3212.74s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/storage/tests       3212.771s

@tombuildsstuff tombuildsstuff self-assigned this Mar 10, 2020
@tombuildsstuff tombuildsstuff added this to the v2.3.0 milestone Mar 19, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @magodo

Thanks for this PR - apologies for the delayed review here!

Taking a look through here rather than casting to/from the Data Plane Resource ID we can instead use the Resource Manager ID for the Storage Container directly, which I've added in #6170. As such whilst this mostly looks good, I hope you don't mind but so that we can get this merged I'm going to push a commit to rebase this & fix up the pending comments now that #6170 has been merged.

Thanks!

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2020-03-19 at 20 03 24

@katbyte katbyte merged commit 79d2bc5 into hashicorp:master Mar 20, 2020
katbyte added a commit that referenced this pull request Mar 20, 2020
@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

katbyte pushed a commit that referenced this pull request Apr 1, 2020
This PR together with the #6035 (merged) address #6014

Fixes #6014
@ghost
Copy link

ghost commented Apr 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants