Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mariadb_server - mark geo_redundant_backup as ForceNew #5961

Merged
merged 3 commits into from
Mar 10, 2020

Conversation

jogleasonjr
Copy link
Contributor

@jogleasonjr jogleasonjr commented Mar 2, 2020

Geo-redundancy state cannot be changed once the server is created (link). This TF provider gives a somewhat generic error:

Error waiting for creation of MariaDB Server "svr-name" (Resource Group "rg-name"): Code="UnsupportedUpdate" Message="Cannot update GeoRedundantBackup for server"

This change just adds a link to the provider docs to help out the next guy.

Geo-redundancy state cannot be changed once the server is created ([https://docs.microsoft.com/en-us/azure/mariadb/concepts-backup#backup-redundancy-options](link). This TF provider gives a somewhat generic error: 

`Error waiting for creation of MariaDB Server "svr-name" (Resource Group "rg-name"): Code="UnsupportedUpdate" Message="Cannot update GeoRedundantBackup for server"`

This change just adds a link to the microsoft docs to help out the next guy.
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but we can go a bit further and add ForceNew: true just below here so that when someone tries to change the attribute, it'll recreate the resource.
Also, we can append Changing this forces a new resource to be created in the attribute description of the docs.

@katbyte katbyte changed the title Add geo-redundant restrictions blurb to the mariadb docs azurerm_mariadb_server - mark geo_redundant_backupas ForceNew Mar 10, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jogleasonjr,

I hope you don't mind but i've pushed the changes @mbfrahry requested so we could get this merged into 2.1 🙂 LGTM now 🚀

@katbyte katbyte changed the title azurerm_mariadb_server - mark geo_redundant_backupas ForceNew azurerm_mariadb_server - mark geo_redundant_backup as ForceNew Mar 10, 2020
@katbyte katbyte merged commit 2c88ff2 into hashicorp:master Mar 10, 2020
katbyte added a commit that referenced this pull request Mar 10, 2020
@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@ghost ghost removed the waiting-response label Mar 11, 2020
@ghost
Copy link

ghost commented Apr 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants