Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_network_watcher_flow_log - support for theinterval_in_minutes property #5851

Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Feb 24, 2020

This PR fix issue #5830

Additionally, fix one bug of example in document, which lacks of specifying account_kind to StorageV2 (which defaults to v1) for storage account, which is required by azurerm_log_analytics_workspace.

@magodo
Copy link
Collaborator Author

magodo commented Feb 24, 2020

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @magodo,

overall this looks great with just some minor name and wording suggestions

website/docs/r/network_watcher_flow_log.html.markdown Outdated Show resolved Hide resolved
"interval": {
Type: schema.TypeInt,
Optional: true,
ValidateFunc: validation.IntAtMost(math.MaxInt32),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are negative values allowed?

workspace_id = "${azurerm_log_analytics_workspace.test.workspace_id}"
workspace_region = "${azurerm_log_analytics_workspace.test.location}"
workspace_resource_id = "${azurerm_log_analytics_workspace.test.id}"
interval = 10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test will fail as this should be

Suggested change
interval = 10
interval_in_minutes = 10

resource.TestCheckResourceAttr(data.ResourceName, "enabled", "true"),
resource.TestCheckResourceAttr(data.ResourceName, "traffic_analytics.#", "1"),
resource.TestCheckResourceAttr(data.ResourceName, "traffic_analytics.0.enabled", "true"),
resource.TestCheckResourceAttr(data.ResourceName, "traffic_analytics.0.interval", "10"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THis check will fail?

@katbyte katbyte changed the title Expose interval for flow log azurerm_network_watcher_flow_log - support for theinterval_in_minutes property Mar 9, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you don't mind @magodo, but i pushed the required changes to get this in for 2.1. LGTM now 👍

@katbyte katbyte force-pushed the flow_log_traffic_analytics_interval branch from 96dd1ef to 41263f9 Compare March 9, 2020 19:46
@katbyte katbyte merged commit 4ea792f into hashicorp:master Mar 9, 2020
katbyte added a commit that referenced this pull request Mar 9, 2020
r0bnet pushed a commit to r0bnet/terraform-provider-azurerm that referenced this pull request Mar 9, 2020
…icorp#5851)

This PR fix issue hashicorp#5830

Additionally, fix one bug of example in document, which lacks of specifying account_kind to StorageV2 (which defaults to v1) for storage account, which is required by azurerm_log_analytics_workspace.
r0bnet pushed a commit to r0bnet/terraform-provider-azurerm that referenced this pull request Mar 9, 2020
@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@ghost ghost removed the waiting-response label Mar 11, 2020
@ghost
Copy link

ghost commented Apr 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants