Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0: Enabling Custom Timeouts, New VM/VMSS Resources & Requires Imports by default #5705

Merged
merged 3 commits into from
Feb 12, 2020

Conversation

tombuildsstuff
Copy link
Contributor

This PR flips the following feature-toggles live by default:

  • Existing Resources will be required to be imported
  • Custom Timeouts will be available on Resources - this will allow you to specify a custom timeout for provisioning the resource in your Terraform Configuration using the timeouts block.
  • New resources for Virtual Machines and Virtual Machine Scale Sets

More details for each of these can be found in #2807 - however this PR only cleans up the Custom Timeouts code - cleanup of the remaining feature toggles will be done in-due-course.

This commit flips on the feature toggle for Custom Timeouts.
In addition this also cleans up a bunch of the default functions
for when this functionality is disabled since these are no longer
needed.
We'll clean up the remaining files once #5508 has been merged
This flips the toggle to on by default however doesn't do any cleanup
due to the sheer number of invocations - instead we'll clean this up
over time as we pass through each resource
@tombuildsstuff tombuildsstuff added this to the v2.0.0 milestone Feb 12, 2020
@tombuildsstuff tombuildsstuff requested a review from a team February 12, 2020 17:29
@ghost ghost added the size/XL label Feb 12, 2020
Copy link
Contributor

@tracypholmes tracypholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 84c4a63 into master Feb 12, 2020
@tombuildsstuff tombuildsstuff deleted the f/2.0 branch February 12, 2020 18:32
tombuildsstuff added a commit that referenced this pull request Feb 12, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants