Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to filter out preview aks releases when fetching versions #5662

Merged

Conversation

matthewi
Copy link
Contributor

No description provided.

@ghost ghost added the size/S label Feb 10, 2020
@matthewi
Copy link
Contributor Author

ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/containers	(cached) [no tests to run]
?   	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/containers/client	[no test files]
=== RUN   TestAccDataSourceAzureRMKubernetesServiceVersions_basic
--- PASS: TestAccDataSourceAzureRMKubernetesServiceVersions_basic (24.44s)
=== RUN   TestAccDataSourceAzureRMKubernetesServiceVersions_filtered
--- PASS: TestAccDataSourceAzureRMKubernetesServiceVersions_filtered (24.68s)
=== RUN   TestAccDataSourceAzureRMKubernetesServiceVersions_nopreview
--- PASS: TestAccDataSourceAzureRMKubernetesServiceVersions_nopreview (25.27s)
PASS

@matthewi matthewi force-pushed the matt-filterpreview-171185663 branch 2 times, most recently from ea30251 to 2a56a48 Compare February 10, 2020 21:53
@matthewi
Copy link
Contributor Author

Rebased against the released version and ran a test locally:

$ terraform apply
data.azurerm_kubernetes_service_versions.preview: Refreshing state...
data.azurerm_kubernetes_service_versions.current: Refreshing state...

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

Outputs:

k8s_all_latest = 1.17.0
k8s_all_versions = [
  "1.13.11",
  "1.13.12",
  "1.14.7",
  "1.14.8",
  "1.15.5",
  "1.15.7",
  "1.16.1",
  "1.16.4",
  "1.17.0",
]
k8s_latest = 1.15.7
k8s_versions = [
  "1.13.11",
  "1.13.12",
  "1.14.7",
  "1.14.8",
  "1.15.5",
  "1.15.7",
]

@matthewi matthewi marked this pull request as ready for review February 10, 2020 22:25
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @matthewi

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can fix up the minor comments (and resolve the website travis issue by rebasing) then this should otherwise be good 👍

Thanks!

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @matthewi

Thanks for pushing those changes - I've left a couple of comments regarding the documentation but this otherwise LGTM 👍

Thanks!

@matthewi
Copy link
Contributor Author

lintrest and tflint pass on my machine. We'll see what Travis does this time 🤞

@ghost ghost removed the waiting-response label Feb 11, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v1.44.0, v2.0.0 Feb 11, 2020
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2020-02-13 at 10 46 01

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 1270eb0 into hashicorp:master Feb 13, 2020
tombuildsstuff added a commit that referenced this pull request Feb 13, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants