'azurerm_storage_account' - Support for 'blob_properties' 'cors_rule'

[jackbatzner]

This PR adds the ability to set cors_rule's for blob's on the storage account. This will resolve #19

The one question I have is around the Azure Go Storage SDK vs. Giovanni Storage SDK. I chose to use the Azure Go Storage SDK. Do we want to use this or Giovanni?

Let me know and I can update if needed

=== RUN TestAccAzureRMStorageAccount_blobProperties
=== PAUSE TestAccAzureRMStorageAccount_blobProperties
=== CONT TestAccAzureRMStorageAccount_blobProperties
--- PASS: TestAccAzureRMStorageAccount_blobProperties (156.69s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/storage/tests 156.958s

[tombuildsstuff]

@Brunhil sorry this has sat for a while / thanks for rebasing this - will take a look now.. first thing tomorrow

[tombuildsstuff]

hey @Brunhil

Thanks for this PR - apologies for the delayed review here! I've taken a look through and left a few comments inline, since there's some matching changes needed outside of the scope of this PR (but related) I hope you don't mind but I'm going to push a commit to fix up these comments & the other changes.

Thanks!

[jackbatzner]

@tombuildsstuff thanks for reviewing this!

[tombuildsstuff]

Ignoring a couple of failing tests (which I've run locally and are also fine)

 $ TF_ACC=1 go test -v ./azurerm/internal/services/storage/tests/ -timeout=60m -run=TestAccAzureRMStorageBlob_blockFromInlineContent
=== RUN   TestAccAzureRMStorageBlob_blockFromInlineContent
=== PAUSE TestAccAzureRMStorageBlob_blockFromInlineContent
=== CONT  TestAccAzureRMStorageBlob_blockFromInlineContent
--- PASS: TestAccAzureRMStorageBlob_blockFromInlineContent (143.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/storage/tests	143.743s

=== RUN   TestAccAzureRMStorageBlob_blockEmptyAccessTier
=== PAUSE TestAccAzureRMStorageBlob_blockEmptyAccessTier
=== CONT  TestAccAzureRMStorageBlob_blockEmptyAccessTier
--- PASS: TestAccAzureRMStorageBlob_blockEmptyAccessTier (222.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/storage/tests	222.224s

[ghost]

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!