Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_route / azurerm_route_table - additions #402

Merged
merged 4 commits into from
Oct 6, 2017
Merged

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Oct 6, 2017

  • azurerm_route_table

    • switching over to using the enum values in the Azure SDK for Go, rather than our own hard-coded strings
    • refactoring the resource to avoid a potential crash
    • migrating Route over from a Set to a List
  • azurerm_route

    • switching over to using the enum values in the Azure SDK for Go, rather than our own hard-coded strings
    • refactoring the resource to avoid a potential crash
    • updating the documentation
    • fixing the sidebar highlight

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

 $ acctests azurerm TestAccAzureRMRoute_
=== RUN   TestAccAzureRMRoute_importBasic
--- PASS: TestAccAzureRMRoute_importBasic (103.64s)
=== RUN   TestAccAzureRMRoute_basic
--- PASS: TestAccAzureRMRoute_basic (99.84s)
=== RUN   TestAccAzureRMRoute_disappears
--- PASS: TestAccAzureRMRoute_disappears (101.34s)
=== RUN   TestAccAzureRMRoute_multipleRoutes
--- PASS: TestAccAzureRMRoute_multipleRoutes (128.76s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	433.614s

@tombuildsstuff tombuildsstuff changed the title azurerm_routes - additions azurerm_route / azurerm_route_table - additions Oct 6, 2017
@tombuildsstuff
Copy link
Contributor Author

Route Table tests:

$ acctests azurerm TestAccAzureRMRouteTable_
=== RUN   TestAccAzureRMRouteTable_importBasic
--- PASS: TestAccAzureRMRouteTable_importBasic (81.93s)
=== RUN   TestAccAzureRMRouteTable_importSingleRoute
--- PASS: TestAccAzureRMRouteTable_importSingleRoute (80.34s)
=== RUN   TestAccAzureRMRouteTable_importMultipleRoutes
--- PASS: TestAccAzureRMRouteTable_importMultipleRoutes (79.26s)
=== RUN   TestAccAzureRMRouteTable_basic
--- PASS: TestAccAzureRMRouteTable_basic (78.18s)
=== RUN   TestAccAzureRMRouteTable_singleRoute
--- PASS: TestAccAzureRMRouteTable_singleRoute (79.23s)
=== RUN   TestAccAzureRMRouteTable_disappears
--- PASS: TestAccAzureRMRouteTable_disappears (78.33s)
=== RUN   TestAccAzureRMRouteTable_withTags
--- PASS: TestAccAzureRMRouteTable_withTags (86.08s)
=== RUN   TestAccAzureRMRouteTable_multipleRoutes
--- PASS: TestAccAzureRMRouteTable_multipleRoutes (80.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	644.161s

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants