Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes crash when no certificate_permissions are defined #374

Merged
merged 1 commit into from
Oct 2, 2017

Conversation

civascu
Copy link

@civascu civascu commented Sep 29, 2017

Fixes the terraform crash when no certificate_permissions have been defined (e.g. when migrating an older config which did not support the certificate_permissions key)

Also fixes a bug where the Permissions.Keys was referenced as the source of the Certificates list

…efined (e.g. when migrating an older config which did not support the certificate_permissions key)

Also fixes a bug where the Permissions.Keys was referenced as the source of the Certificates list
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @civascu

Thanks for this PR - I've taken a look and this LGTM :)

@tombuildsstuff
Copy link
Contributor

Tests pass:

$ acctests azurerm TestAccAzureRMKeyVault
=== RUN   TestAccAzureRMKeyVaultKey_importBasicEC
--- PASS: TestAccAzureRMKeyVaultKey_importBasicEC (74.86s)
=== RUN   TestAccAzureRMKeyVaultKey_importBasicRSA
--- PASS: TestAccAzureRMKeyVaultKey_importBasicRSA (76.85s)
=== RUN   TestAccAzureRMKeyVaultKey_importBasicRSAHSM
--- PASS: TestAccAzureRMKeyVaultKey_importBasicRSAHSM (82.93s)
=== RUN   TestAccAzureRMKeyVaultKey_importComplete
--- PASS: TestAccAzureRMKeyVaultKey_importComplete (78.65s)
=== RUN   TestAccAzureRMKeyVaultSecret_importBasic
--- PASS: TestAccAzureRMKeyVaultSecret_importBasic (78.65s)
=== RUN   TestAccAzureRMKeyVaultSecret_importComplete
--- PASS: TestAccAzureRMKeyVaultSecret_importComplete (76.35s)
=== RUN   TestAccAzureRMKeyVault_importBasic
--- PASS: TestAccAzureRMKeyVault_importBasic (70.74s)
=== RUN   TestAccAzureRMKeyVaultKey_basicEC
--- PASS: TestAccAzureRMKeyVaultKey_basicEC (76.65s)
=== RUN   TestAccAzureRMKeyVaultKey_basicRSA
--- PASS: TestAccAzureRMKeyVaultKey_basicRSA (78.75s)
=== RUN   TestAccAzureRMKeyVaultKey_basicRSAHSM
--- PASS: TestAccAzureRMKeyVaultKey_basicRSAHSM (81.41s)
=== RUN   TestAccAzureRMKeyVaultKey_complete
--- PASS: TestAccAzureRMKeyVaultKey_complete (77.42s)
=== RUN   TestAccAzureRMKeyVaultKey_update
--- PASS: TestAccAzureRMKeyVaultKey_update (91.55s)
=== RUN   TestAccAzureRMKeyVaultChild_validateName
--- PASS: TestAccAzureRMKeyVaultChild_validateName (0.00s)
=== RUN   TestAccAzureRMKeyVaultSecret_parseID
--- PASS: TestAccAzureRMKeyVaultSecret_parseID (0.00s)
=== RUN   TestAccAzureRMKeyVaultSecret_basic
--- PASS: TestAccAzureRMKeyVaultSecret_basic (76.80s)
=== RUN   TestAccAzureRMKeyVaultSecret_complete
--- PASS: TestAccAzureRMKeyVaultSecret_complete (78.34s)
=== RUN   TestAccAzureRMKeyVaultSecret_update
--- PASS: TestAccAzureRMKeyVaultSecret_update (89.70s)
=== RUN   TestAccAzureRMKeyVault_name
--- PASS: TestAccAzureRMKeyVault_name (0.00s)
=== RUN   TestAccAzureRMKeyVault_basic
--- PASS: TestAccAzureRMKeyVault_basic (70.96s)
=== RUN   TestAccAzureRMKeyVault_complete
--- PASS: TestAccAzureRMKeyVault_complete (74.22s)
=== RUN   TestAccAzureRMKeyVault_update
--- PASS: TestAccAzureRMKeyVault_update (83.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1418.245s

@tombuildsstuff tombuildsstuff merged commit e7b5a1c into hashicorp:master Oct 2, 2017
tombuildsstuff added a commit that referenced this pull request Oct 2, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants