additions to azurerm_storage_account

[tombuildsstuff]

• Support for File Encryption. Fixes azurerm_storage_account: crash when importing resource with file encryption enabled #80
• Adding additional Import tests
• Support for Custom Domains on Storage Accounts. Fixes azurerm - storage account resource has no support for custom domains #15
• Splitting the storage account Tier and Replication out into separate fields. Suggested by @cchildress in #117 (which also fixes Support replacing storage_account when changing account type #110)

Unfortunately testing Custom Domains is harder than anticipated - since it needs a static DNS name and storage name, which need to be globally unique. For this reason I've manually confirmed this works, but haven't included an acceptance test for it at the moment.

[tombuildsstuff]

State migration tests pass:

 $ acctests azurerm TestAzureRMStorageAccountMigrateState
=== RUN   TestAzureRMStorageAccountMigrateState
2017/09/28 19:12:45 [INFO] Found AzureRM Storage Account State v0; migrating to v1
2017/09/28 19:12:45 [DEBUG] ARM Storage Account Attributes before Migration: map[string]string{"account_type":"Standard_LRS"}
2017/09/28 19:12:45 [DEBUG] ARM Storage Account Attributes after State Migration: map[string]string{"account_tier":"Standard", "account_replication_type":"LRS", "account_type":"Standard_LRS"}
2017/09/28 19:12:45 [INFO] Found AzureRM Storage Account State v0; migrating to v1
2017/09/28 19:12:45 [DEBUG] ARM Storage Account Attributes before Migration: map[string]string{"account_type":"Premium_GRS"}
2017/09/28 19:12:45 [DEBUG] ARM Storage Account Attributes after State Migration: map[string]string{"account_type":"Premium_GRS", "account_tier":"Premium", "account_replication_type":"GRS"}
--- PASS: TestAzureRMStorageAccountMigrateState (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	0.014s

Acceptance tests passed when I ran them earlier - but I'm re-running them now to confirm

[tombuildsstuff]

[vancluever]

LGTM with a minor nitpick about the markdown wrapping 👍

[vancluever]

Wrap the markdown at 80 characters?

[tombuildsstuff]

Taking a look into this - we've got a ton of cases which have gone beyond this limit - so I'm going to leave this as-is for now and we'll do a provider wide cleanup in a bit

[vancluever]

I know that feeling 😉 👍

[mbfrahry]

LGTM with a minor comment

[mbfrahry]

Just want to confirm that we are guaranteed to have 2 keys

[tombuildsstuff]

Yep, afaik

[dominik-lekse]

@tombuildsstuff I have been working on contributing additional test cases and used the recent master with this feature merged.

I noticed this pr breaks the test cases which involve a storage account, e.g. TestAccAzureRMVirtualMachine_basicLinuxMachine. Those tests fail with the following message.

make testacc TEST=./azurerm TESTARGS='-run=^TestAccAzureRMVirtualMachine_basicLinuxMachine$$'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=^TestAccAzureRMVirtualMachine_basicLinuxMachine$ -timeout 120m
=== RUN   TestAccAzureRMVirtualMachine_basicLinuxMachine
--- FAIL: TestAccAzureRMVirtualMachine_basicLinuxMachine (0.01s)
	testing.go:434: Step 0 error: Configuration is invalid.

		Warnings: []string{"azurerm_storage_account.test: \"account_type\": [DEPRECATED] This field has been split into `account_tier` and `account_replication_type`"}

		Errors: []string{"azurerm_storage_account.test: \"account_replication_type\": required field is not set", "azurerm_storage_account.test: \"account_tier\": required field is not set"}
FAIL
exit status 1
FAIL	github.com/terraform-providers/terraform-provider-azurerm/azurerm	0.034s
make: *** [testacc] Error 1

I assume they need to be adapted to the changed introduced in this pr.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!