Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU support for Linux Azure Container Instances #3053

Merged
merged 6 commits into from
Mar 17, 2019
Merged

Add GPU support for Linux Azure Container Instances #3053

merged 6 commits into from
Mar 17, 2019

Conversation

neilpeterson
Copy link
Contributor

@neilpeterson neilpeterson commented Mar 14, 2019

Issue - #3052

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @neilpeterson

Thanks for this PR :)

Taking a look through this mostly LGTM - I've left some minor comments inline but if we can get those fixed up this should be good to merge 👍

Thanks!

azurerm/resource_arm_container_group.go Outdated Show resolved Hide resolved
azurerm/resource_arm_container_group.go Outdated Show resolved Hide resolved
azurerm/resource_arm_container_group.go Outdated Show resolved Hide resolved
azurerm/resource_arm_container_group.go Outdated Show resolved Hide resolved
azurerm/resource_arm_container_group.go Outdated Show resolved Hide resolved
azurerm/resource_arm_container_group.go Show resolved Hide resolved
website/docs/r/container_group.html.markdown Outdated Show resolved Hide resolved
website/docs/r/container_group.html.markdown Outdated Show resolved Hide resolved
website/docs/r/container_group.html.markdown Outdated Show resolved Hide resolved
website/docs/r/container_group.html.markdown Outdated Show resolved Hide resolved
@neilpeterson
Copy link
Contributor Author

@tombuildsstuff thanks for the coaching and suggestions Tom. I've addressed each of them.

@ghost ghost removed the waiting-response label Mar 16, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @neilpeterson

Thanks for pushing those changes - besides a couple of minor fixes needed for the test to pass (where the field had been renamed but the assertion hadn't) this otherwise LGTM 👍. I hope you don't mind but since the assertion is the only thing pending, so that we can get this merged I'm going to push a commit to fix this

Thanks!

azurerm/resource_arm_container_group_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_container_group_test.go Outdated Show resolved Hide resolved
@tombuildsstuff
Copy link
Contributor

The test suite prior to fixing the test config:

Screenshot 2019-03-17 at 19 00 24

The failing test after updating the test config:

Screenshot 2019-03-17 at 18 59 56

@tombuildsstuff tombuildsstuff merged commit de06dcd into hashicorp:master Mar 17, 2019
tombuildsstuff added a commit that referenced this pull request Mar 17, 2019
@neilpeterson
Copy link
Contributor Author

@tombuildsstuff thanks a bunch for helping push this through.

@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 17, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants