Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Renaming/Duplication: azurerm_monitor_autoscale_setting / azurerm_log_analytics_linked_service #2768

Merged
merged 17 commits into from
Jan 28, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR spans a few different areas, as a result of passing through the entire codebase looking for deprecations:

  • Introduces a new resource azurerm_monitor_autoscale_setting to replace the azurerm_autoscale_setting resource.
  • Introduces a new resource azurerm_log_analytics_linked_service to replace the azurerm_log_analytics_workspace_linked_service resource.
  • azurerm_postgresql_server - support for version 10 and 10.2
  • azurerm_application_gateway - deprecating the fqdn_list field in favour of fqdns
  • azurerm_application_gateway - deprecating the ip_address_list field in favour of ip_addresses

Copy link
Contributor

@metacpp metacpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tombuildsstuff Thanks for the effort to rename the resources.

I did a quick look through the PR.

The only difference between resourceArmAutoScaleSetting and resourceArmMonitorAutoScaleSetting is the extra deprecate message. Maybe we can just refactor resourceArmAutoScaleSetting a bit to support renaming scenario considering that the internal schema and functionality between these 2 functions are exactly the same ? Just my 2 cents.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from a couple comments LGTM @tombuildsstuff 👍

@@ -146,6 +146,7 @@ func resourceArmNetworkInterface() *schema.Resource {
Set: schema.HashString,
},

// TODO: does this want deprecating & a virtual resource for 2.0?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

website/docs/r/servicebus_queue.html.markdown Show resolved Hide resolved
Copy link
Contributor

@metacpp metacpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone through all the changes, mostly LGTM and ready to be merged if we can address the comments in line.

website/docs/r/servicebus_queue.html.markdown Show resolved Hide resolved
website/docs/r/application_gateway.html.markdown Outdated Show resolved Hide resolved
website/docs/r/application_gateway.html.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@metacpp metacpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the suggestions in line.

@tombuildsstuff tombuildsstuff dismissed metacpp’s stale review January 28, 2019 15:46

dismissing since changes have been pushed

@tombuildsstuff tombuildsstuff merged commit f367512 into master Jan 28, 2019
@tombuildsstuff tombuildsstuff deleted the f/renaming-resources branch January 28, 2019 16:02
tombuildsstuff added a commit that referenced this pull request Jan 28, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants