Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Service: Updating Connection Strings to a Set #2609

Merged
merged 2 commits into from
Jan 7, 2019

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jan 7, 2019

Fixes #651

(I'm intentionally leaving the Data Source as a list, rather than converting it to a Set since otherwise it's inaccessible)

@tombuildsstuff tombuildsstuff added this to the 1.21.0 milestone Jan 7, 2019
@tombuildsstuff tombuildsstuff requested a review from a team January 7, 2019 14:48
@ghost ghost added the size/L label Jan 7, 2019
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I like that you mixed the order of the connection_string blocks in tests to ensure there's no dependence on their order!

@tombuildsstuff
Copy link
Contributor Author

Resource Tests pass:

screenshot 2019-01-07 at 15 42 18

@tombuildsstuff
Copy link
Contributor Author

Data Source tests pass:

screenshot 2019-01-07 at 17 43 14

@tombuildsstuff tombuildsstuff merged commit 4bd6aaa into master Jan 7, 2019
@tombuildsstuff tombuildsstuff deleted the b/app-service-connection-strings branch January 7, 2019 17:45
tombuildsstuff added a commit that referenced this pull request Jan 7, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants