Provider function to replace validation.NoZeroValues #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katbyte
requested changes
Dec 7, 2018
azurerm/helpers/validate/strings.go
Outdated
|
|
||
| newv := strings.TrimSpace(v) | ||
|
|
||
| if len(newv) == 0 { |
There was a problem hiding this comment.
this could be:
if strings.TrimSpace(v) == "" {There was a problem hiding this comment.
Yep... doesn't make sense to spin up a new var when you can do it inline.
Co-Authored-By: jeffreyCline <[email protected]>
Co-Authored-By: jeffreyCline <[email protected]>
Co-Authored-By: jeffreyCline <[email protected]>
Co-Authored-By: jeffreyCline <[email protected]>
Co-Authored-By: jeffreyCline <[email protected]>
tombuildsstuff
approved these changes
Dec 7, 2018
There was a problem hiding this comment.
one minor thing in addition to @katbyte's comments but this otherwise LGTM 👍
| Value: "1 ", | ||
| TestName: "OneSpace", | ||
| ErrCount: 0, | ||
| }, |
There was a problem hiding this comment.
it'd be good to add a test case for 5 empty spaces in here too
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2462