Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_elasticpool: moved elastic_pool_properties properties to the top level #2378

Merged
merged 2 commits into from
Nov 22, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Nov 22, 2018

Also fixes some potential crash points.

@katbyte katbyte added service/mssql Microsoft SQL Server refactor labels Nov 22, 2018
@katbyte katbyte added this to the 1.20.0 milestone Nov 22, 2018
@katbyte katbyte requested review from WodansSon and a team November 22, 2018 21:56
@ghost ghost added the size/M label Nov 22, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions for fields to remove - but this otherwise LGTM 👍

azurerm/resource_arm_mssql_elasticpool.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mssql_elasticpool.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mssql_elasticpool.go Show resolved Hide resolved
katbyte added a commit that referenced this pull request Nov 22, 2018
katbyte added a commit that referenced this pull request Nov 22, 2018
@katbyte
Copy link
Collaborator Author

katbyte commented Nov 22, 2018

tests pass:
screen shot 2018-11-22 at 15 21 57

@katbyte katbyte merged commit d4b1dd9 into master Nov 22, 2018
@katbyte katbyte deleted the b-mssql-elasticpool-prop branch November 22, 2018 23:52
katbyte added a commit that referenced this pull request Nov 22, 2018
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants