Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Keyvault network ACL with multiple subnet ids #2324

Merged

Conversation

leonfs
Copy link
Contributor

@leonfs leonfs commented Nov 15, 2018

Fixes #2129

I first added an integration test that reproduced the error by adding a new subnet to the Key Vault network ACL list. The test that creates it has two subnets, while there is another test that updates to go back to one subnet.

The function sliceContainsValue used to fix the problem, has also been previously used throughout the code base for similar scenarios.

@ghost ghost added the size/S label Nov 15, 2018
@leonfs leonfs changed the title Fix keyvault multiple subnet ids Fix Keyvault network ACL with multiple subnet ids Nov 15, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @leonfs :)

@tombuildsstuff
Copy link
Contributor

tombuildsstuff commented Nov 19, 2018

Ignoring a known/transient test failure, tests pass:

screenshot 2018-11-19 at 13 04 33

@tombuildsstuff tombuildsstuff merged commit 5e178d7 into hashicorp:master Nov 19, 2018
tombuildsstuff added a commit that referenced this pull request Nov 19, 2018
@leonfs
Copy link
Contributor Author

leonfs commented Nov 20, 2018

My pleasure @tombuildsstuff. I took it as an opportunity to try out the new Go modules. Initialising the project as a module and running the tests worked at the first attempt, great surprise.

@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
@leonfs leonfs deleted the fix-keyvault-multiple-subnet-ids branch March 7, 2019 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_key_vault - Virtual Network Rules not working with multiple subnet id's
2 participants