Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Service: support for php 7.2 #2308

Merged
merged 2 commits into from
Nov 14, 2018
Merged

App Service: support for php 7.2 #2308

merged 2 commits into from
Nov 14, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Fixes #2307

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screenshot 2018-11-14 at 11 35 59

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One little thing that's a non-blocker.

website/docs/r/app_service_slot.html.markdown Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff merged commit c0c2c4c into master Nov 14, 2018
@tombuildsstuff tombuildsstuff deleted the f/app-service-php72 branch November 14, 2018 18:28
tombuildsstuff added a commit that referenced this pull request Nov 14, 2018
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants