Fixed value length check

[WodansSon]

No description provided.

[JunyiYi]

Of course.

[tombuildsstuff]

hey @jeffreyCline

Thanks for this PR :)

Taking a quick look at the portal it appears the maximum supported value is 30 (and not 128):

As such could we invert this change (to fix the comments/error message/tests rather than the limit?) - but in general I'm 👍 with this change :)

Thanks!

[katbyte]

Might I suggest actually hitting the API? multiple times i've found the value in the portal to be vastly different then what the API will allow.

[metacpp]

Taking a quick look at the portal it appears the maximum supported value is 30 (and not 128):

But its length definition is between 3 and 64 in API Swagger:
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/databricks/resource-manager/Microsoft.Databricks/stable/2018-04-01/databricks.json#L684

[WodansSon]

According to the azure-sdk-for-go they too have implemented the length as 3 to 64...
https://github.com/Azure/azure-sdk-for-go/blob/ff2671f6653891a6025a1ee25ce033100a9f090a/services/databricks/mgmt/2018-04-01/databricks/workspaces.go#L161

[metacpp]

According to the azure-sdk-for-go they too have implemented the length as 3 to 64...

@jeffreyCline this is because of SDK was generated from API swagger:
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/databricks/resource-manager/Microsoft.Databricks/stable/2018-04-01/databricks.json#L684

[tombuildsstuff]

Thanks for pushing those changes @jeffreyCline - this now LGTM 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!