Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/dev_test_virtual_network: support for controlling the subnet #2041

Merged
merged 3 commits into from
Oct 11, 2018
Merged

r/dev_test_virtual_network: support for controlling the subnet #2041

merged 3 commits into from
Oct 11, 2018

Conversation

tombuildsstuff
Copy link
Contributor

DevTest Virtual Networks can have a single Subnet - this PR adds support for obtaining it's name & setting properties on this Subnet

This is a requirement for DevTest Virtual Machines

@tombuildsstuff tombuildsstuff added this to the 1.17.0 milestone Oct 9, 2018
@ghost ghost added the size/L label Oct 9, 2018
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

$ acctests azurerm TestAccAzureRMDevTestVirtualNetwork_
=== RUN   TestAccAzureRMDevTestVirtualNetwork_basic
--- PASS: TestAccAzureRMDevTestVirtualNetwork_basic (408.41s)
=== RUN   TestAccAzureRMDevTestVirtualNetwork_subnet
--- PASS: TestAccAzureRMDevTestVirtualNetwork_subnet (408.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	818.334s

katbyte
katbyte approved these changes Oct 9, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one very minor non blocking comment LGTM 👍

azurerm/resource_arm_dev_test_virtual_network.go
return outputs
}

func validateDevTestVirtualNetworkUsagePermissionType() schema.SchemaValidateFunc {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor this could go in the validate package

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix this in #2058 since it's built on top of this branch 👍

@tombuildsstuff tombuildsstuff mentioned this pull request Oct 11, 2018
Merged
@tombuildsstuff tombuildsstuff removed the request for review from mbfrahry October 11, 2018 08:53
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screenshot 2018-10-11 at 11 12 26

@tombuildsstuff tombuildsstuff merged commit cdfcd89 into master Oct 11, 2018
@tombuildsstuff tombuildsstuff deleted the f/dtl-virtual-network branch October 11, 2018 21:25
tombuildsstuff added a commit that referenced this pull request Oct 11, 2018
@tombuildsstuff
Updating to include #2041
710bac7
tombuildsstuff added a commit that referenced this pull request Oct 11, 2018
@tombuildsstuff
Updating to include #2041
080e097
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
enhancement service/devtestlabs size/L
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @katbyte