Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow postgres version 10.0 #1457

Merged
merged 4 commits into from
Jun 28, 2018
Merged

allow postgres version 10.0 #1457

merged 4 commits into from
Jun 28, 2018

Conversation

featheredtoast
Copy link
Contributor

We're attempting to get a Postgres 10 instance up through Terraform, but are unable to due to restrictive version checks.

This is a fix that adds support "10.0" as a valid version string until the azure go api adds a proper "10.0" enum.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @featheredtoast,

Thank you for this PR, it mostly LGTM. Could we get a todo comment and update the documentation?

Thanks

@@ -122,6 +122,7 @@ func resourceArmPostgreSQLServer() *schema.Resource {
ValidateFunc: validation.StringInSlice([]string{
string(postgresql.NineFullStopFive),
string(postgresql.NineFullStopSix),
"10.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get a todo comment here mentioning switching it over to the enum once it is in the SDK?

@featheredtoast
Copy link
Contributor Author

OK done - Updated the docs, added the requested TODO comment.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@featheredtoast,

Thanks for the updates! I forgot to mention adding a test, hope you don't' mind but i added it myself so we could include this in 1.8. LGTM now 👍

Also for future reference we don't update the chaneglog in the PR. That is a separate step we do after merge.

Thanks for the contribution!

@katbyte katbyte modified the milestones: 1.9.0, 1.8.0 Jun 28, 2018
@katbyte katbyte merged commit fb23aa3 into hashicorp:master Jun 28, 2018
katbyte added a commit that referenced this pull request Jun 28, 2018
@featheredtoast
Copy link
Contributor Author

No worries, just happy to have gotten this in quickly - thanks for fixing it up! ❤️

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants