Authorization: upgrading to the 2018-01-01 Preview SDK
#1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests pass
```
$ acctests azurerm TestAccAzureRMRole
=== RUN TestAccAzureRMRoleDefinition_importBasic
--- PASS: TestAccAzureRMRoleDefinition_importBasic (24.38s)
=== RUN TestAccAzureRMRoleDefinition_importComplete
--- PASS: TestAccAzureRMRoleDefinition_importComplete (14.14s)
=== RUN TestAccAzureRMRoleAssignment
=== RUN TestAccAzureRMRoleAssignment/basic
=== RUN TestAccAzureRMRoleAssignment/basic/roleName
=== RUN TestAccAzureRMRoleAssignment/basic/builtin
=== RUN TestAccAzureRMRoleAssignment/basic/custom
=== RUN TestAccAzureRMRoleAssignment/basic/emptyName
=== RUN TestAccAzureRMRoleAssignment/import
=== RUN TestAccAzureRMRoleAssignment/import/basic
=== RUN TestAccAzureRMRoleAssignment/import/custom
--- PASS: TestAccAzureRMRoleAssignment (118.70s)
--- PASS: TestAccAzureRMRoleAssignment/basic (77.01s)
--- PASS: TestAccAzureRMRoleAssignment/basic/roleName (19.05s)
--- PASS: TestAccAzureRMRoleAssignment/basic/builtin (17.87s)
--- PASS: TestAccAzureRMRoleAssignment/basic/custom (22.59s)
--- PASS: TestAccAzureRMRoleAssignment/basic/emptyName (17.51s)
--- PASS: TestAccAzureRMRoleAssignment/import (41.69s)
--- PASS: TestAccAzureRMRoleAssignment/import/basic (21.88s)
--- PASS: TestAccAzureRMRoleAssignment/import/custom (19.80s)
=== RUN TestAccAzureRMRoleDefinition_basic
--- PASS: TestAccAzureRMRoleDefinition_basic (14.59s)
=== RUN TestAccAzureRMRoleDefinition_complete
--- PASS: TestAccAzureRMRoleDefinition_complete (12.99s)
=== RUN TestAccAzureRMRoleDefinition_update
--- PASS: TestAccAzureRMRoleDefinition_update (22.03s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 206.861s
```
Tests pass:
```
$ acctests azurerm TestAccAzureRMRole
=== RUN TestAccAzureRMRoleDefinition_importBasic
--- PASS: TestAccAzureRMRoleDefinition_importBasic (24.71s)
=== RUN TestAccAzureRMRoleDefinition_importComplete
--- PASS: TestAccAzureRMRoleDefinition_importComplete (14.30s)
=== RUN TestAccAzureRMRoleAssignment
=== RUN TestAccAzureRMRoleAssignment/basic
=== RUN TestAccAzureRMRoleAssignment/basic/emptyName
=== RUN TestAccAzureRMRoleAssignment/basic/roleName
=== RUN TestAccAzureRMRoleAssignment/basic/dataActions
=== RUN TestAccAzureRMRoleAssignment/basic/builtin
=== RUN TestAccAzureRMRoleAssignment/basic/custom
=== RUN TestAccAzureRMRoleAssignment/import
=== RUN TestAccAzureRMRoleAssignment/import/basic
=== RUN TestAccAzureRMRoleAssignment/import/custom
--- PASS: TestAccAzureRMRoleAssignment (140.30s)
--- PASS: TestAccAzureRMRoleAssignment/basic (95.32s)
--- PASS: TestAccAzureRMRoleAssignment/basic/emptyName (19.34s)
--- PASS: TestAccAzureRMRoleAssignment/basic/roleName (15.95s)
--- PASS: TestAccAzureRMRoleAssignment/basic/dataActions (19.54s)
--- PASS: TestAccAzureRMRoleAssignment/basic/builtin (17.11s)
--- PASS: TestAccAzureRMRoleAssignment/basic/custom (23.38s)
--- PASS: TestAccAzureRMRoleAssignment/import (44.98s)
--- PASS: TestAccAzureRMRoleAssignment/import/basic (22.07s)
--- PASS: TestAccAzureRMRoleAssignment/import/custom (22.91s)
=== RUN TestAccAzureRMRoleDefinition_basic
--- PASS: TestAccAzureRMRoleDefinition_basic (13.78s)
=== RUN TestAccAzureRMRoleDefinition_complete
--- PASS: TestAccAzureRMRoleDefinition_complete (12.98s)
=== RUN TestAccAzureRMRoleDefinition_update
--- PASS: TestAccAzureRMRoleDefinition_update (23.25s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 229.356s
```
tombuildsstuff
force-pushed
the
authorization-sdk
branch
from
ef4379b
to
30be37b
Compare
radeksimko
approved these changes
May 24, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to create a Role Assignment using a Role that's got Data Actions assigned returns the following error:
I'd consider this an API bug (and have raised this SDK issue) - but we can work around this in Terraform by upgrading to the new Preview API (which I've done here).
This PR also fixes the intermittently failing Role Assignments tests, where the tests were running in parallel using the same Role Definition (thus causing conflicts).
Fixes #1280