azurerm_kubernetes_cluster: Support for BYO kubelet_identity

[aristosvo]

Fixes #11980. Feature in Preview.

Register before testing:

az feature register --namespace Microsoft.ContainerService -n CustomKubeletIdentityPreview
# wait until registered:
watch az feature list -o table --query "\"[?contains(name, 'Microsoft.ContainerService/CustomKubeletIdentityPreview')].{Name:name,State:properties.state}\""
az provider register --namespace Microsoft.ContainerService

Acceptance Tests run:

• TestAccKubernetesCluster_userAssignedKubeletIdentity (with BYO Kubelet Identity)
• TestAccKubernetesCluster_userAssignedIdentity (without BYO Kubelet Identity)

❯ make acctests SERVICE='containers' TESTARGS='-run=TestAccKubernetesCluster_userAssigned'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/containers -run=TestAccKubernetesCluster_userAssigned -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/06/02 13:43:06 [DEBUG] not using binary driver name, it's no longer needed
2021/06/02 13:43:08 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccKubernetesCluster_userAssignedIdentity
=== PAUSE TestAccKubernetesCluster_userAssignedIdentity
=== RUN   TestAccKubernetesCluster_userAssignedKubeletIdentity
=== PAUSE TestAccKubernetesCluster_userAssignedKubeletIdentity
=== CONT  TestAccKubernetesCluster_userAssignedIdentity
=== CONT  TestAccKubernetesCluster_userAssignedKubeletIdentity
--- PASS: TestAccKubernetesCluster_userAssignedIdentity (615.75s)
--- PASS: TestAccKubernetesCluster_userAssignedKubeletIdentity (710.19s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/containers    714.228s

ToDo:

• Docs

[mbfrahry]

This is looking good but I do have a doc question to make things a little more clear

[mbfrahry]

LGTM! Thanks @aristosvo!

[dwrusse]

Is there any way to enable the kubeletpreview provider via terraform? I was hoping to embed this into a module that will be used on several different accounts.

[aristosvo]

@dwrusse Would https://www.terraform.io/docs/language/resources/provisioners/local-exec.html maybe work for you combined with az cli?

[dwrusse]

Potentially, yes. I was hoping for a more "native" terraform method, but I agree with you that there likely isn't. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.