azurerm_key_vault_certificate_data: Support certificate bundles and add support for ECDSA keys

[favoretti]

Potentially fixes #10909

[favoretti]

At least I haven't broken current acceptance test :)

$ TF_ACC=1 go test -v ./azurerm/internal/services/keyvault -timeout=1000m -run='TestAccDataSourceKeyVaultCertificateData_basic'
2021/05/26 21:33:43 [DEBUG] not using binary driver name, it's no longer needed
2021/05/26 21:33:43 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccDataSourceKeyVaultCertificateData_basic
=== PAUSE TestAccDataSourceKeyVaultCertificateData_basic
=== CONT  TestAccDataSourceKeyVaultCertificateData_basic
--- PASS: TestAccDataSourceKeyVaultCertificateData_basic (343.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/keyvault	344.729s

Will work on adding tests for new use-cases shortly.

[favoretti]

$ TF_ACC=1 go test -v ./azurerm/internal/services/keyvault -timeout=1000m -run='TestAccDataSourceKeyVaultCertificateData'
2021/05/26 23:08:16 [DEBUG] not using binary driver name, it's no longer needed
2021/05/26 23:08:16 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccDataSourceKeyVaultCertificateData_basic
=== PAUSE TestAccDataSourceKeyVaultCertificateData_basic
=== RUN   TestAccDataSourceKeyVaultCertificateData_ecdsa_PFX
=== PAUSE TestAccDataSourceKeyVaultCertificateData_ecdsa_PFX
=== RUN   TestAccDataSourceKeyVaultCertificateData_ecdsa_PEM
=== PAUSE TestAccDataSourceKeyVaultCertificateData_ecdsa_PEM
=== RUN   TestAccDataSourceKeyVaultCertificateData_rsa_bundle_PEM
=== PAUSE TestAccDataSourceKeyVaultCertificateData_rsa_bundle_PEM
=== RUN   TestAccDataSourceKeyVaultCertificateData_rsa_single_PEM
=== PAUSE TestAccDataSourceKeyVaultCertificateData_rsa_single_PEM
=== RUN   TestAccDataSourceKeyVaultCertificateData_rsa_bundle_PFX
=== PAUSE TestAccDataSourceKeyVaultCertificateData_rsa_bundle_PFX
=== CONT  TestAccDataSourceKeyVaultCertificateData_basic
=== CONT  TestAccDataSourceKeyVaultCertificateData_rsa_single_PEM
=== CONT  TestAccDataSourceKeyVaultCertificateData_ecdsa_PEM
=== CONT  TestAccDataSourceKeyVaultCertificateData_rsa_bundle_PFX
=== CONT  TestAccDataSourceKeyVaultCertificateData_rsa_bundle_PEM
=== CONT  TestAccDataSourceKeyVaultCertificateData_ecdsa_PFX
--- PASS: TestAccDataSourceKeyVaultCertificateData_ecdsa_PFX (330.67s)
--- PASS: TestAccDataSourceKeyVaultCertificateData_rsa_bundle_PEM (361.86s)
--- PASS: TestAccDataSourceKeyVaultCertificateData_ecdsa_PEM (362.05s)
--- PASS: TestAccDataSourceKeyVaultCertificateData_basic (362.23s)
--- PASS: TestAccDataSourceKeyVaultCertificateData_rsa_bundle_PFX (363.32s)
--- PASS: TestAccDataSourceKeyVaultCertificateData_rsa_single_PEM (366.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/keyvault	367.696s

[favoretti]

TC is a happy camper too.

[katbyte]

Thanks @favoretti - LGTM 👍

[ghost]

This has been released in version 2.61.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.61.0"
}
# ... other configuration ...

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.