Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade eventgrid to 2020-10-15-preview #11746

Merged
merged 1 commit into from
May 18, 2021
Merged

deps: upgrade eventgrid to 2020-10-15-preview #11746

merged 1 commit into from
May 18, 2021

Conversation

favoretti
Copy link
Collaborator

Which inherently introduces Microsoft.PolicyInsights.PolicyStates
system topic type.

$ TF_ACC=1 go test -v ./azurerm/internal/services/eventgrid -timeout=1000m -run 'TestAccEventGridSystemTopic_policyStates'
2021/05/17 14:03:50 [DEBUG] not using binary driver name, it's no longer needed
2021/05/17 14:03:50 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccEventGridSystemTopic_policyStates
=== PAUSE TestAccEventGridSystemTopic_policyStates
=== CONT  TestAccEventGridSystemTopic_policyStates
--- PASS: TestAccEventGridSystemTopic_policyStates (141.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventgrid	143.004s

image

Fixes: #11523

Which inherently introduces `Microsoft.PolicyInsights.PolicyStates`
system topic type.

```
$ TF_ACC=1 go test -v ./azurerm/internal/services/eventgrid -timeout=1000m -run 'TestAccEventGridSystemTopic_policyStates'
2021/05/17 14:03:50 [DEBUG] not using binary driver name, it's no longer needed
2021/05/17 14:03:50 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccEventGridSystemTopic_policyStates
=== PAUSE TestAccEventGridSystemTopic_policyStates
=== CONT  TestAccEventGridSystemTopic_policyStates
--- PASS: TestAccEventGridSystemTopic_policyStates (141.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventgrid	143.004s
```

Fixes: #11523
@favoretti
Copy link
Collaborator Author

image

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @favoretti 👍

@tombuildsstuff tombuildsstuff added this to the v2.60.0 milestone May 18, 2021
@tombuildsstuff tombuildsstuff merged commit 5ce76d0 into hashicorp:master May 18, 2021
tombuildsstuff added a commit that referenced this pull request May 18, 2021
@ghost
Copy link

ghost commented May 21, 2021

This has been released in version 2.60.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.60.0"
}
# ... other configuration ...

favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_eventgrid_system_topic doesn't support 'Microsoft.PolicyInsights.PolicyStates' topic type
2 participants