azurerm_frontdoor: check for nil value in future.Response()

[favoretti]

@WodansSon apparently this can be nil? 😟

Fixes #11715

[WodansSon]

Yes, this is related to change in the RP where the CNAME has to be deleted first. I have tried to check future for nil already and it had no effect on the panic outcome. I will give this PR a try to see if my mileage will vary with what you have done. 🚀

[WodansSon]

@favoretti, thanks for this PR... this does stop the panic with a better experience. It now errors with:

Error: deleting Front Door "exampleFrontdoor" (Resource Group "example-rg"): frontdoor.FrontDoorsClient#Delete: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="Conflict" Message="Cannot delete frontend endpoint \"example-custom.wodans-son.co.uk\" because it is still directly or indirectly (using \"afdverify\" prefix) CNAMEd to front door \"exampleFrontdoor.azurefd.net\". Please remove the DNS CNAME records and try again."

[WodansSon]

@favoretti thanks for the PR this LGTM 🚀

[WodansSon]

[ghost]

This has been released in version 2.60.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.60.0"
}
# ... other configuration ...

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.