Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in a reference for the older "App" App Service Plans #1156

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

tombuildsstuff
Copy link
Contributor

From my understanding the App Service Kind app is the older alias for creating a Windows App Service Plan. This is available in the Swagger example, the Azure API Docs [which actually come from the Swagger] and are confirmed in #1148

This PR adds support for this alias which fixes #1148

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff merged commit 37ad400 into master Apr 24, 2018
@tombuildsstuff tombuildsstuff deleted the app-service-plan-app branch April 24, 2018 15:04
tombuildsstuff added a commit that referenced this pull request Apr 24, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_app_service_plan - Unable to configure imported ASP (says kind is "app")
2 participants