Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/azurerm_web_application_firewall_policy support OWASP 3.2 rule set #11244

Merged
merged 1 commit into from
Apr 8, 2021
Merged

r/azurerm_web_application_firewall_policy support OWASP 3.2 rule set #11244

merged 1 commit into from
Apr 8, 2021

Conversation

anderius
Copy link

@anderius anderius commented Apr 7, 2021

Fixes #11243

katbyte
katbyte approved these changes Apr 7, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anderius - LGTM 👍

@katbyte katbyte added this to the v2.55.0 milestone Apr 7, 2021
katbyte
katbyte previously requested changes Apr 7, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anderius - looks like there is a conflict with the changelog - we encourage contributors to not modify it for this reason. COuld we remove that change and i'll get this merged for this weeks release? thanks

@anderius
Copy link
Author

anderius commented Apr 8, 2021

@katbyte: Sorry about that! I have removed the change from the changelog now.

@anderius anderius requested a review from katbyte April 8, 2021 07:30
tombuildsstuff
tombuildsstuff approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @anderius

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review April 8, 2021 07:38

dismissing since changes have been pushed

@tombuildsstuff tombuildsstuff merged commit 7434db9 into hashicorp:master Apr 8, 2021
tombuildsstuff added a commit that referenced this pull request Apr 8, 2021
@tombuildsstuff
updating to include #11244
5765bf6
@anderius anderius deleted the feature/owasp_3_2 branch April 8, 2021 08:33
@ghost
Copy link

ghost commented Apr 9, 2021

This has been released in version 2.55.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.55.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@katbyte katbyte Awaiting requested review from katbyte

Assignees
No one assigned
Labels
documentation enhancement service/firewall size/XS
Projects
None yet
Milestone
v2.55.0
Development

Successfully merging this pull request may close these issues.

Support for OWASP 3.2 in azurerm_web_application_firewall_policy
3 participants
@anderius @tombuildsstuff @katbyte