Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource azurerm_spring_cloud_app_mysql_association #11229

Merged
merged 3 commits into from
Apr 13, 2021

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Apr 7, 2021

second PR to associate spring cloud app with mysql server

image

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @njuCZ

Thanks for this PR.

I've taken a look through and left some comments inline but this is off to a good start - if we can fix up the comments then we should be able to take another look.

Thanks!

@njuCZ
Copy link
Contributor Author

njuCZ commented Apr 8, 2021

@tombuildsstuff thanks for your review. I have updated this PR, all acctest could pass

@ghost ghost removed the waiting-response label Apr 8, 2021
@katbyte katbyte added this to the v2.56.0 milestone Apr 13, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuCZ - LGTM 👍

@katbyte katbyte merged commit 8b40243 into hashicorp:master Apr 13, 2021
katbyte added a commit that referenced this pull request Apr 13, 2021
@ghost
Copy link

ghost commented Apr 16, 2021

This has been released in version 2.56.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.56.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants