Redis Cache: support for clusters on the internal network #1086
Conversation
tombuildsstuff
force-pushed
the
f/redis-internal-network
branch
2 times, most recently
from
6383573
to
12164cf
Compare
tombuildsstuff
force-pushed
the
f/redis-internal-network
branch
from
12164cf
to
7042a80
Compare
tombuildsstuff
changed the title
|
Tests pass:
|
| if resp.ShardCount != nil { | ||
| d.Set("shard_count", resp.ShardCount) | ||
| if props := resp.Properties; props != nil { | ||
| d.Set("ssl_port", props.SslPort) |
There was a problem hiding this comment.
Shall we build a helper method to flatten it ?
There was a problem hiding this comment.
nope - we only do that for complex (e.g. nested) field, a single field isn't necessary
|
@tombuildsstuff LGTM and I resolved the conflict for you, please double check if there is anything wrong. |
|
Great work guys. Could this be used for all tiers or just premium tier? |
|
@hafizullah Terraform works with the same SKU's as available in Azure - from memory support for this is limited to the Premium SKU, but I may be wrong :) |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
This PR adds support for Redis Caches on the Internal Network
@metacpp / @JunyiYi / @paultyng / @katbyte I've named the field for the Private Static IP Address
private_static_ip_address(the API/Docs expose this asStaticIP- "Static IP address. Required when deploying a Redis cache inside an existing Azure Virtual Network.") to avoid any confusion that a Public Static IP address could be used - but perhaps this should match the API - what do you think?Tasks:
Fixes #82