Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns_zone: Compute resourceId from the parser, add state migration, switch dns package to generated IDs #10786

Merged
merged 5 commits into from
Mar 5, 2021
Merged

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Mar 2, 2021

Fixes #10778

@ghost ghost added the size/M label Mar 2, 2021
@favoretti favoretti changed the title dns_zone: Compute resourceId from the parser, add state migration [WIP] dns_zone: Compute resourceId from the parser, add state migration Mar 2, 2021
@ghost ghost added size/L and removed size/M labels Mar 2, 2021
@favoretti
Copy link
Collaborator Author

Complete output is not included, due to DEBUG logging, but complete suite passed.

PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/dns	687.482s

@favoretti favoretti changed the title [WIP] dns_zone: Compute resourceId from the parser, add state migration dns_zone: Compute resourceId from the parser, add state migration, switch dns package to generated IDs Mar 2, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @favoretti

Thanks for pushing those changes - taking a look through on the whole this looks pretty good, but we should be able to remove the redundant Get call since we're not using that result as we're creating the ID's here - but if we can fix those up this should otherwise be good to merge 👍

Thanks!

azurerm/internal/services/dns/dns_a_record_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/dns/dns_aaaa_record_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/dns/dns_caa_record_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/dns/dns_cname_record_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/dns/dns_mx_record_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/dns/dns_ptr_record_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/dns/dns_srv_record_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/dns/dns_txt_record_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/dns/dns_zone_resource.go Outdated Show resolved Hide resolved
@favoretti
Copy link
Collaborator Author

hey @favoretti

Thanks for pushing those changes - taking a look through on the whole this looks pretty good, but we should be able to remove the redundant Get call since we're not using that result as we're creating the ID's here - but if we can fix those up this should otherwise be good to merge 👍

Thanks!

Ah, I thought that one served as additional creation verification :)

@ghost ghost added size/XL and removed size/L labels Mar 3, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.50.0 milestone Mar 4, 2021
@katbyte katbyte merged commit 911adb1 into hashicorp:master Mar 5, 2021
katbyte added a commit that referenced this pull request Mar 5, 2021
@ghost
Copy link

ghost commented Mar 5, 2021

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error creating azurerm_dns_zone with mixed-case Resource Group: Provider produced inconsistent final plan
3 participants