azurerm_api_management: Enable Tenant Access

[patst]

Implementation for #8578 .

Management REST API can be enabled/ disabled and the primary/ secondary Keys can be used as output variables.

Feedback welcome ;-)

[patst]

integration test passed in my subscription

[katbyte]

THanks for the pr @patst - are you sure the tests pass? they all appear to be failing for us with the tenant_access block being updated.

enant_access.#: "1" => "0"

[patst]

@katbyte thanks for the feedback. Only the "positive test" seems to work.

The problems is to separate between a disabled tenant_access with

tenant_access {
 enabled= false
}

and a missing tenant_access block. The REST API is returning for both cases the same response.

I will try to figure out a solution. I think the flattenApiManagementTenantAccessSettings function is the place to look for a solution.

If you have any advise that would be great as well

[patst]

@katbyte I changed the tenant_access block to Computed to handle the case if it is not set at all.

The tests I executed passed:

TF_ACC=1 go test ./azurerm/internal/services/apimanagement/api_management_resource_test.go -v -run=TestAccApiManagement_customProps -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccApiManagement_customProps
=== PAUSE TestAccApiManagement_customProps
=== CONT  TestAccApiManagement_customProps
--- PASS: TestAccApiManagement_customProps (2985.12s)
PASS
ok      command-line-arguments  2986.535s

TF_ACC=1 go test ./azurerm/internal/services/apimanagement/api_management_resource_test.go -v -run=TestAccApiManagement_tenantAccess -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccApiManagement_tenantAccess
=== PAUSE TestAccApiManagement_tenantAccess
=== CONT  TestAccApiManagement_tenantAccess
--- PASS: TestAccApiManagement_tenantAccess (2593.46s)
PASS

TF_ACC=1 go test ./azurerm/internal/services/apimanagement/api_management_resource_test.go -v -run=TestAccApiManagement_signInSignUpSettings -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccApiManagement_signInSignUpSettings
=== PAUSE TestAccApiManagement_signInSignUpSettings
=== CONT  TestAccApiManagement_signInSignUpSettings
--- PASS: TestAccApiManagement_signInSignUpSettings (2766.83s)
PASS

I guess the remaining ones will pass as well.

[katbyte]

Thanks @patst - tests are looking better now, just a couple coments more inline to address and this should be good ro merge

[katbyte]

Thanks @patst - LGTM

[ghost]

This has been released in version 2.49.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.49.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!