Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubernetes_cluster acctest by changing length of Windows Profile password #10452

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Feb 3, 2021

Fixes AccTest TestAccKubernetesCluster_windowsProfile error Code="WindowsProfilePasswordInvalid" Message="Invalid adminPassword. Error: Length of password is invalid. Required length: [14, 123]. Minimum password length required by AKS for AzSecPack is longer. Please see https://docs.microsoft.com/en-us/rest/api/compute/virtualmachinescalesets/createorupdate#virtualmachinescalesetosprofile"

Acceptance test:

TF_ACC=1 go test -v ./azurerm/internal/services/containers/ -run=TestAccKubernetesCluster_windowsProfile -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccKubernetesCluster_windowsProfile
=== PAUSE TestAccKubernetesCluster_windowsProfile
=== CONT  TestAccKubernetesCluster_windowsProfile
--- PASS: TestAccKubernetesCluster_windowsProfile (586.67s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/containers   587.980s

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @aristosvo 👍

@tombuildsstuff tombuildsstuff added this to the v2.46.0 milestone Feb 3, 2021
@tombuildsstuff tombuildsstuff merged commit e40f9c0 into hashicorp:master Feb 3, 2021
tombuildsstuff added a commit that referenced this pull request Feb 3, 2021
@aristosvo aristosvo deleted the fix-windows-password branch February 4, 2021 06:09
@ghost
Copy link

ghost commented Feb 5, 2021

This has been released in version 2.46.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.46.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 6, 2021
@aristosvo aristosvo restored the fix-windows-password branch April 14, 2023 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants