Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recoveryservices - support for recovery_public_ip #10446

Merged
merged 11 commits into from
Feb 10, 2021

Conversation

MitchDrage
Copy link
Contributor

Resolving issue 8837.

Depends on pull 10373

Changes:

  • Created "recovery_public_ip" field within "network_interface" of an "azurerm_site_recovery_replicated_vm" resource.
  • Added recovery public IP to existing test with the attached results.
  • Adjusted tests to use list of IP ranges in subnet due to the previous method being deprecated.
  • Set the recovery target network settings to ForceNew: False since they can be changed after deployment without re-running the protection of the VM (reprotection can take an hour or more during an apply).
  • Updated webpage to reference the new field.
  • Remove resource "azurerm_subnet" "test2_3" from test as it was previously unused.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MitchDrage - LGTM 👍

@katbyte katbyte added this to the v2.47.0 milestone Feb 10, 2021
@katbyte katbyte merged commit 8f2de38 into hashicorp:master Feb 10, 2021
katbyte added a commit that referenced this pull request Feb 10, 2021
@MitchDrage MitchDrage deleted the recoveryservices-recoverypubip branch February 10, 2021 22:20
@MitchDrage MitchDrage restored the recoveryservices-recoverypubip branch February 10, 2021 22:20
@ghost
Copy link

ghost commented Feb 11, 2021

This has been released in version 2.47.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.47.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants