Fix a crash in azurerm_storage_account_datasource

[favoretti]

It crashes if the name passed to it is an empty string.

Fixes #10369

[favoretti]

Now instead of crashing it errors out gracefully:

data "azurerm_storage_account" "this" {
  name                = ""
  resource_group_name = azurerm_resource_group.this.name
}

$ ta

Warning: Provider development overrides are in effect

The following provider development overrides are set in the CLI configuration:
 - hashicorp/azurerm in /Users/vlazarenko/go/bin

The behavior may therefore not match any released version of the provider and
applying changes may cause the state to become incompatible with published
releases.

Acquiring state lock. This may take a few moments...

Error: name ("") can only consist of lowercase letters and numbers, and must be between 3 and 24 characters long

  on sa.tf line 1, in data "azurerm_storage_account" "this":
   1: data "azurerm_storage_account" "this" {

[katbyte]

Thanks @favoretti - LGTM 👍

[ghost]

This has been released in version 2.46.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.46.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!