Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/azurerm_servicebus_namespace - Allowed setting messaging units capacity to 16 for Premium SKU #10337

Merged

Conversation

leewilson86
Copy link
Contributor

@leewilson86 leewilson86 commented Jan 27, 2021

Allowed the azurerm_servicebus_namespace resource to support the capacity of 16 for the number of messaging units to be set when using the Premium SKU.

Screenshot 2021-01-27 at 17 41 03

Microsoft documentation (https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-premium-messaging) only shows support for a capacity of up to 8, but we have been able to request 16 due to high levels of throttling at 8. Microsoft has confirmed going up to 16 is not possible in the portal, but customers can request it via a support ticket. This change is essential for us as Terraform wants to keep reverting our capacity back to 8:

------------------------------------------------------------------------
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  ~ update in-place
Terraform will perform the following actions:
  # azurerm_servicebus_namespace.servicebusNameSpace[0] will be updated in-place
  ~ resource "azurerm_servicebus_namespace" "servicebusNameSpace" {
      ~ capacity                            = 16 -> 8
        default_primary_connection_string   = (sensitive value)
        default_primary_key                 = (sensitive value)
        default_secondary_connection_string = (sensitive value)
        default_secondary_key               = (sensitive value)
        id                                  = "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/prdsbrg/providers/Microsoft.ServiceBus/namespaces/prdsb"
        location                            = "canadaeast"
        name                                = "prdsb"
        resource_group_name                 = "prdsbrg"
        sku                                 = "premium"
        tags                                = {}
        zone_redundant                      = false
    }
Plan: 0 to add, 1 to change, 0 to destroy.

But when we cannot enforce 16 in config due to validation rules within the provider, which this PR now addresses:

Error: expected capacity to be one of [0 1 2 4 8], got 16
  on ../../modules/resources/paas/serviceBus/nameSpace.tf line 1, in resource "azurerm_servicebus_namespace" "servicebusNameSpace":
   1: resource "azurerm_servicebus_namespace" "servicebusNameSpace" {

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @leewilson86

@katbyte katbyte merged commit 8059891 into hashicorp:master Jan 27, 2021
katbyte added a commit that referenced this pull request Jan 27, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.45.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 27, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants