Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_cosmosdb_cassandra_table #10328

Merged
merged 40 commits into from
Feb 3, 2021
Merged

New resource: azurerm_cosmosdb_cassandra_table #10328

merged 40 commits into from
Feb 3, 2021

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Jan 27, 2021

Fixes #10327

@ghost ghost added the size/XL label Jan 27, 2021
@favoretti favoretti marked this pull request as draft January 27, 2021 11:19
@favoretti favoretti marked this pull request as ready for review January 27, 2021 16:33
@favoretti
Copy link
Collaborator Author

$ TF_ACC=1 go test -v ./azurerm/internal/services/cosmos -timeout=1000m -run=TestAccCosmosDbCassandraTable_basic
=== RUN   TestAccCosmosDbCassandraTable_basic
=== PAUSE TestAccCosmosDbCassandraTable_basic
=== CONT  TestAccCosmosDbCassandraTable_basic
--- PASS: TestAccCosmosDbCassandraTable_basic (1056.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/cosmos	1057.545s

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @favoretti

Thanks for this PR - taking a look through on the whole this looks pretty good to me, my main question is whether it's worth parsing this information from a cassandra_keyspace_id field, rather than taking 3 separate strings for this information - since the Keyspace is likely to be provisioned at the same time - WDYT?

Thanks!

website/docs/r/cosmosdb_cassandra_table.html.markdown Outdated Show resolved Hide resolved
website/docs/r/cosmosdb_cassandra_table.html.markdown Outdated Show resolved Hide resolved
website/docs/r/cosmosdb_cassandra_table.html.markdown Outdated Show resolved Hide resolved
website/docs/r/cosmosdb_cassandra_table.html.markdown Outdated Show resolved Hide resolved
website/docs/r/cosmosdb_cassandra_table.html.markdown Outdated Show resolved Hide resolved
@favoretti
Copy link
Collaborator Author

$ TF_ACC=1 go test -v ./azurerm/internal/services/cosmos -timeout=1000m -run=TestAccCosmosDbCassandraTable_basic
=== RUN   TestAccCosmosDbCassandraTable_basic
=== PAUSE TestAccCosmosDbCassandraTable_basic
=== CONT  TestAccCosmosDbCassandraTable_basic
--- PASS: TestAccCosmosDbCassandraTable_basic (1055.85s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/cosmos	1057.009s

@djsly
Copy link
Contributor

djsly commented Jan 28, 2021

We were about to do it with azurerm_resource_group_template_deployment super excited to see this almost ready, @tombuildsstuff if you think this as a chance to be in the next release, please update the labels, I will halt some of my work! if not, azurerm_resource_group_template_deployment it will be :(

@favoretti
Copy link
Collaborator Author

@djsly 2.45 has been cut, so the best chance is it'll be in 2.46, which is next week. If I were to guess - this is good to merge.

@djsly
Copy link
Contributor

djsly commented Jan 28, 2021

Thansk a lot. I'll have high hope for the next release then !

@tombuildsstuff tombuildsstuff added this to the v2.46.0 milestone Feb 3, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @favoretti

Thanks for pushing those changes - apologies for the delayed re-review here!

Taking a look through this mostly LGTM - however I believe we can also remove the resource_group_name field since this can be inferred from the Table ID, WDYT?

Thanks!

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @favoretti

favoretti and others added 22 commits February 3, 2021 18:50
@favoretti
Copy link
Collaborator Author

$ TF_ACC=1 go test -v ./azurerm/internal/services/cosmos -timeout=1000m -run=TestAccCosmosDbCassandraTable_basic
=== RUN   TestAccCosmosDbCassandraTable_basic
=== PAUSE TestAccCosmosDbCassandraTable_basic
=== CONT  TestAccCosmosDbCassandraTable_basic
--- PASS: TestAccCosmosDbCassandraTable_basic (1051.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/cosmos	1052.527s

@tombuildsstuff tombuildsstuff merged commit bc373d3 into hashicorp:master Feb 3, 2021
tombuildsstuff added a commit that referenced this pull request Feb 3, 2021
@ghost
Copy link

ghost commented Feb 5, 2021

This has been released in version 2.46.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.46.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Cosmosdb Cassandra tables
3 participants