Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_factory_dataset_delimited_text: Expose compression_codec #10182

Merged

Conversation

jackbatzner
Copy link
Contributor

Expose Compression Codec as requested in #9980

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @Brunhil. There's just one change needed in a test check, otherwise this LGTM.

@katbyte katbyte added this to the v2.44.0 milestone Jan 21, 2021
…imited_text_resource_test.go

Co-authored-by: Tom Bamford <[email protected]>
@ghost ghost added size/XS and removed size/S labels Jan 21, 2021
@tombuildsstuff tombuildsstuff modified the milestones: v2.44.0, v2.45.0 Jan 21, 2021
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katbyte
Copy link
Collaborator

katbyte commented Jan 21, 2021

linting failure seems spurious, merging

@katbyte katbyte merged commit 4bc7d38 into hashicorp:master Jan 21, 2021
katbyte added a commit that referenced this pull request Jan 21, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.45.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 21, 2021
@jackbatzner jackbatzner deleted the datafactory-dataset-compression-codec branch March 2, 2021 02:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants