Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_media_streaming_policy #10133

Merged
merged 7 commits into from
Jan 27, 2021
Merged

New resource: azurerm_media_streaming_policy #10133

merged 7 commits into from
Jan 27, 2021

Conversation

jcanizalez
Copy link
Contributor

Hi there introducing the support for new resource azurerm_media_streaming_policy. This PR resolves #10010

Checked:

  • Update Documentation
  • Add new Acceptance Test and verified that the tests pass successfully
  • Check linting

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jcanizalez

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can fix up the comments (and the tests pass) then this should otherwise be good to go 👍

Thanks!

website/docs/r/media_streaming_policy.html.markdown Outdated Show resolved Hide resolved
website/docs/r/media_streaming_policy.html.markdown Outdated Show resolved Hide resolved
website/docs/r/media_streaming_policy.html.markdown Outdated Show resolved Hide resolved
website/docs/r/media_streaming_policy.html.markdown Outdated Show resolved Hide resolved
@jcanizalez
Copy link
Contributor Author

hi @tombuildsstuff

Thanks for your code review. I already applied your suggestions, so you can take a look please

Thanks

@tombuildsstuff tombuildsstuff modified the milestones: v2.44.0, v2.45.0 Jan 21, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @jcanizalez

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2021-01-27 at 17 48 39

@tombuildsstuff tombuildsstuff merged commit 9dd8bb0 into hashicorp:master Jan 27, 2021
tombuildsstuff added a commit that referenced this pull request Jan 27, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.45.0"
}
# ... other configuration ...

@jcanizalez jcanizalez deleted the media_streaming_policy branch January 28, 2021 19:45
@ghost
Copy link

ghost commented Feb 27, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Streaming Policy in Azure Media Services Account
2 participants