Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: upgrading github.com/Azure/azure-sdk-for-go to v49.2.0 #10042

Merged
merged 10 commits into from
Jan 6, 2021

Conversation

tombuildsstuff
Copy link
Contributor

This PR upgrades to v49.2.0 of the Azure SDK for Go, which includes the following breaking changes:

  • Attestation: 2018-09-01 is now out of Preview.
  • Virtual Machines can now opt-into Force Deletion - but this is in Preview so we're not for now.
  • EventHubs/Security Center: updating the constant names
  • Synapse: working around breaking type changes

Fixes #9683

@tombuildsstuff tombuildsstuff requested a review from a team January 4, 2021 18:23
@ghost ghost added the size/XXL label Jan 4, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff - LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

Attestation looks good:

Screenshot 2021-01-06 at 12 53 20

@tombuildsstuff tombuildsstuff merged commit 98e9833 into master Jan 6, 2021
@tombuildsstuff tombuildsstuff deleted the deps/azure-sdk branch January 6, 2021 15:00
tombuildsstuff added a commit that referenced this pull request Jan 6, 2021
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade go sdk version from v48.1.0 to latest one
3 participants