Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding data_cache_config to postgresql module #531

Merged
merged 10 commits into from
Nov 8, 2023

Conversation

nityanavali1
Copy link
Contributor

No description provided.

@isaurabhuttam
Copy link
Collaborator

/gcbrun

@nityanavali1 nityanavali1 marked this pull request as ready for review November 1, 2023 17:31
@nityanavali1
Copy link
Contributor Author

nityanavali1 commented Nov 1, 2023

PR is ready to be merged. Need Approval

@imrannayer
Copy link
Collaborator

Waiting for PR #523 to merge.

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer
Copy link
Collaborator

@nityanavali1 according to documentation this feature is only available for mysql.

data_cache_enabled - (Optional) Whether data cache is enabled for the instance. Defaults to false Can only be used with MYSQL.

@nityanavali1
Copy link
Contributor Author

nityanavali1 commented Nov 2, 2023

@nityanavali1 according to documentation this feature is only available for mysql.

data_cache_enabled - (Optional) Whether data cache is enabled for the instance. Defaults to false Can only be used with MYSQL.

@nityanavali1
Copy link
Contributor Author

@nityanavali1 according to documentation this feature is only available for mysql.
data_cache_enabled - (Optional) Whether data cache is enabled for the instance. Defaults to false Can only be used with MYSQL.

@imrannayer Can you approve this change based on above comments?

@imrannayer
Copy link
Collaborator

@nityanavali1 can you plz enable this feature in this example so we can test this feature?
Also do you know why postgres page is disabled in official doc

@nityanavali1
Copy link
Contributor Author

nityanavali1 commented Nov 6, 2023

@nityanavali1 can you plz enable this feature in this example so we can test this feature? Also do you know why postgres page is disabled in official doc

The official docs will be updated on Nov 8. Although the rollout is 100% complete for this feature. As of today customers can go ahead and create postgres instances with data cache enabled https://screenshot.googleplex.com/8fvJsiEDJmQ3TWm. If the recommendation is to wait until docs update. Will do so.

For

  • can you plz enable this feature in this example so we can test this feature?
    Not sure how this can be achieved as postgres module (modules/postgresql/variables.tf) does not expose the variable for data cache without this PR being submitted.

@imrannayer
Copy link
Collaborator

@nityanavali1 thanks for confirming the feature. You pass the value in example as part of your PR. It will work fine during the test for your PR.

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer
Copy link
Collaborator

/gcbrun

@nityanavali1
Copy link
Contributor Author

/gcbrun

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer
Copy link
Collaborator

/gcbrun

1 similar comment
@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit f04d617 into terraform-google-modules:master Nov 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants