Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add connector params timeout and export from replica #406

Conversation

adeusmondo
Copy link
Contributor

This PR is to add two features:

  • Enable the export module to run on replica instance.
  • Add connection parameter to set timeout in workflow, if the process takes more then 1800s (default value).

@adeusmondo adeusmondo requested a review from a team as a code owner January 12, 2023 21:47
@google-cla
Copy link

google-cla bot commented Jan 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@comment-bot-dev
Copy link

@adeusmondo
Thanks for the PR! 🚀
✅ Lint checks have passed.

@g-awmalik
Copy link
Contributor

@adeusmondo - thanks for the PR. Can you please resolve the conflicts with master?

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik g-awmalik merged commit e563f8a into terraform-google-modules:master Sep 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants