Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metrics block from slo-generator v1.3.0 makes TF 0.13 module fail #55

Closed
ocervell opened this issue Oct 19, 2020 · 0 comments · Fixed by #69
Closed

New metrics block from slo-generator v1.3.0 makes TF 0.13 module fail #55

ocervell opened this issue Oct 19, 2020 · 0 comments · Fixed by #69

Comments

@ocervell
Copy link

ocervell commented Oct 19, 2020

Terraform struggles with complex nested variables validation. For instance, it cannot take a list of maps with arbitrary types for the map values: all values need to be either all required, or all of the same type. There is no concept of optional variables either.

See here and here for more context on those issues.

In order to avoid getting the issue with any addition in the SLO Config or Error Budget Policy, we should pass the SLO config file paths (with eventual variable replacement happening inside the module) instead of SLO config file contents, to bypass the variable validation (which slo-generator will take care of anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant