add enable_namespace_creation flag and start testing with 1.10 #968
+38
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
ZhengzheYang
force-pushed
the
enable-namespace
branch
from
ba9133c to
791ed8e
Compare
|
Defaulting to ASM 1.10 for testing. The test has passed for 1.10. Switching back to 1.9 |
ZhengzheYang
force-pushed
the
enable-namespace
branch
5 times, most recently
from
e18434e to
29ec234
Compare
ZhengzheYang
force-pushed
the
enable-namespace
branch
from
29ec234 to
c9f75b3
Compare
ZhengzheYang
changed the title
ZhengzheYang
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
bharathkkb
requested changes
Aug 5, 2021
ZhengzheYang
force-pushed
the
enable-namespace
branch
2 times, most recently
from
94a4667 to
e0621ed
Compare
bharathkkb
approved these changes
Aug 5, 2021
bharathkkb
reviewed
Aug 5, 2021
ZhengzheYang
force-pushed
the
enable-namespace
branch
2 times, most recently
from
ef93f25 to
76fc426
Compare
ZhengzheYang
force-pushed
the
enable-namespace
branch
from
76fc426 to
3f6a4d3
Compare
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…ogle-modules#968) * add enable_namespace_creation flag and start testing with 1.10 * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASM 1.10 has a new flag for
install_asmto create theistio-systemnamespace for the user, if the user opts in.