Asm overlay path #921
Merged
Asm overlay path #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
bharathkkb
requested changes
Jun 7, 2021
There was a problem hiding this comment.
Thanks for the PR
Looks like the converge step is failing
I believe this is due to CUSTOM_OVERLAYS_COMMAND becoming CUSTOM_OVERLAYS_COMMAND is --custom_overlay /workspace/test/fixtures/simple_zonal_with_asm/none although there are none specified
install_asm_1.9 --verbose --project_id ci-gke-asm-... --cluster_name simple-zonal-asm-cluster-...--cluster_location us-central1-a --mode install --option envoy-access-log --custom_overlay /workspace/test/fixtures/simple_zonal_with_asm/none --output_dir ./simple-zonal-asm-cluster-...-outdir --enable_cluster_roles --enable_cluster_labels --enable_gcp_components
install_asm_1.9: [ERROR]: Couldn't find yaml file /workspace/test/fixtures/simple_zonal_with_asm/none.
+ cleanup
+ rm -rf /tmp/kubectl_wrapper_27218_27705
|
@bharathkkb let me know if you need other changes, thnx! |
bharathkkb
approved these changes
Jun 8, 2021
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
* use absolute path for overlay files similar to service account key file * fix for multiple files * fix for multiple files * fix for multiple files * fix for multiple files * fix for multiple files * fix for none Co-authored-by: Bharath KKB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the fix @ameer00 and I made for
KEY_FILE_COMMAND_SNIPPETto add the full path to the service account key file, theCUSTOM_OVERLAYS_COMMANDalso needs the full path since the script generating the command is in a different location from where it is used, so it will not resolve relative paths correctly.