Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: Revert attribution fix #845

Merged
merged 11 commits into from
Mar 12, 2021
Merged

revert: Revert attribution fix #845

merged 11 commits into from
Mar 12, 2021

Conversation

bharathkkb
Copy link
Member

reverts #830 fixes #843

@bharathkkb bharathkkb requested review from Jberlinsky and a team as code owners March 11, 2021 23:47
@bharathkkb bharathkkb marked this pull request as draft March 11, 2021 23:48
@comment-bot-dev
Copy link

comment-bot-dev commented Mar 12, 2021 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb changed the title [wip]: Revert attribution fix revert: Revert attribution fix Mar 12, 2021
@bharathkkb
Copy link
Member Author

/gcbrun

@bharathkkb bharathkkb marked this pull request as ready for review March 12, 2021 15:03
@bharathkkb bharathkkb requested a review from morgante March 12, 2021 15:06
@bharathkkb
Copy link
Member Author

Tested locally with 0.14.5 and in CI https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/runs/2092831361

@bharathkkb bharathkkb merged commit c398144 into master Mar 12, 2021
@bharathkkb bharathkkb deleted the revert-attribution-fix branch March 12, 2021 19:32
@bharathkkb bharathkkb mentioned this pull request Mar 12, 2021
Open
@rwkarg
Copy link

rwkarg commented Mar 12, 2021 •
edited
Loading

What's the expectation for a new release with this? We're currently pinned to v13.1.0 waiting for this.

Found the PR for the release: #847

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@bharathkkb
fix: Revert attribution fix (terraform-google-modules#845)
501ec74 
* revert: Fix attribution for safer cluster modules (terraform-google-modules#830)

* update to 14.0

* temporarily test with 0.14x tf image in ci

* bump setup pf versions

* bump setup provider

* fix setup pf

* kitchen fix for 0.14

* bump networking

* bump iap example

* switch back to 0.13 tests

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error coming while executing the script: Error: value must be known
4 participants
@bharathkkb @comment-bot-dev @rwkarg @morgante