Add new property to explicitly return GKE private_endpoint #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgante
reviewed
Mar 5, 2021
|
Thanks for the PR! 🚀 |
morgante
approved these changes
Mar 5, 2021
bharathkkb
approved these changes
Mar 9, 2021
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…auth module (terraform-google-modules#841) * Add new property to explicitly return GKE private_endpoint * Return private_endpoint if explicitly requested, otherwise return default endpoint Co-authored-by: Bharath KKB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #828 on the
authmodule. A new flaguse_private_endpointis introduced. If this flag is set totrue, theprivate_endpointproperty of the GKE cluster is looked up.If
use_private_endpointis set tofalse(default), thedata.google_container_cluster.gke_cluster.private_cluster_config[0].public_endpointwill be used if available with a fallback to the default GKEendpointproperty.