Support for ACM install for non GKE clusters #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Grant roles/artifactregistry.reader to created service account …
Merge to latest
Merge latest from upstream
Merge latest from master
abhinavrau
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
|
Thanks for the PR! 🚀 |
Remove unneeded format call. Co-authored-by: Bharath KKB <[email protected]>
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
) * Tested with EKS and GKE * Reformatting to support PR for ACM support for non GKE Clusters * update docs * fix shellcheck errors * Update modules/k8s-operator-crd-support/main.tf Remove unneeded format call. Co-authored-by: Bharath KKB <[email protected]> Co-authored-by: Abhinav Rau <[email protected]> Co-authored-by: Bharath KKB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for non GKE clusters is added by passing a
use_existing_contextflag to the acm module.use_existing_contextflag to the acm module to indicate to use the current context when waiting for gatekeeper to be ready.use_existing_contextflag to k8s-operator-crd-support module to pass on towait_for_gatekeeper.shscript.wait_for_gatekeeper.shto use current context to wait for gatekeeper services and deployment to be ready.