Hub registration using kubeconfig and labels support #785
Conversation
feat: Grant roles/artifactregistry.reader to created service account …
abhinavrau
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
|
Thanks for the PR! 🚀 |
There was a problem hiding this comment.
@abhinavrau I had a chance to test this out and unfortunately looks like GKE with kubeconfig does not work.
Registering a non-GKE Cluster. Using current-context to register Hub membership.
ERROR: (gcloud.container.hub.memberships.register) Invalid value for [--context]: --context cannot be used for GKE clusters. Either --gke-uri | --gke-cluster must be specified
Works with a kind cluster so maybe we drop the gke kubeconfig example and just mention in the docs how to to use it with kind? Testing with kind would also probably need some dind setup since all our tests run within a docker image.
specify PROJECT_ID to be more specific Co-authored-by: Bharath KKB <[email protected]>
fix number of arguments check Co-authored-by: Bharath KKB <[email protected]>
@bharathkkb Thanks for response and reviewing the code. I have committed your suggested changes. As far as the example with kubeconfig, I have modified the example to use a kind cluster so users can see how to use the hub module with kubeconfig. I understand it will be difficult to do an integration test with dind but is it necessary for all examples to have an integration test? I see there are some examples that don't have an integration test (e.g. examples/simple_zonal_with_acm) so will it be an issue to the have an example using it even though the build process does not run the example? |
|
@abhinavrau LGTM, we dont need to have an integration test for every example |
…-google-modules#785) * initial support for using kubecontext for hub registration * Tested with GKE using kubectl * Tested with GKE using kubectl * Fixed typo in README * Fixed formatting errors * Fixed formatting errors * Fixed formatting and renamed example to be more consistent * Fixed formatting and renamed example to be more consistent * remove test files * fixed typo in README * use a flag to switch gke vs kubeconfig instead of having two scripts * Update modules/hub/scripts/gke_hub_registration.sh specify PROJECT_ID to be more specific Co-authored-by: Bharath KKB <[email protected]> * Update modules/hub/scripts/gke_hub_unregister.sh fix number of arguments check Co-authored-by: Bharath KKB <[email protected]> * update simple_zonal_with_hub_kubeconfig to use kind cluster Co-authored-by: Abhinav Rau <[email protected]> Co-authored-by: Bharath KKB <[email protected]> Co-authored-by: Morgante Pell <[email protected]>
Fix for one of the items in #637.
Please review and let me know if this looks good. I will wait for feedback on the tests as there are no integration tests for hub specifically. See comment on 637