feat: Enable ACM feature on hub #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-pharaoh
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
|
Thanks for the PR! 🚀 |
|
/gcbrun |
morgante
suggested changes
Oct 22, 2020
There was a problem hiding this comment.
Looks like we need to enable hub on our test project, defined here: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/test/setup/main.tf#L50
Operation "operations/acf.66e7d7f4-f02b-4b8e-8168-cf64d1e1d6fc" finished successfully.
API [gkehub.googleapis.com] not enabled on project [106532254158].
Would you like to enable and retry (this will take a few minutes)?
(y/N)?
ERROR: (gcloud.alpha.container.hub.config-management.enable) PERMISSION_DENIED: GKE Hub has not been used in project 106532254158 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/gkehub.googleapis.com/overview?project=106532254158 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.
- '@type': type.googleapis.com/google.rpc.Help
links:
- description: Google developers console API activation
url: https://console.developers.google.com/apis/api/gkehub.googleapis.com/overview?project=106532254158
- '@type': type.googleapis.com/google.rpc.ErrorInfo
domain: googleapis.com
metadata:
consumer: projects/106532254158
service: gkehub.googleapis.com
reason: SERVICE_DISABLED
|
We can also use the "gke-project-asm" which has hub already enabled |
|
@morgante @bharathkkb |
|
@cloud-pharaoh Permissions are also managed in test/setup: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/test/setup/iam.tf |
bharathkkb
approved these changes
Nov 4, 2020
bharathkkb
approved these changes
Dec 4, 2020
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
* enable acm * update README * enable gkehub api on test project * Add Hub Admin role to SA * add service account key file * add additional components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.